ROX-28223: Pause-reconcile handler#426
Merged
perdasilva merged 6 commits intooperator-framework:mainfrom Mar 13, 2025
Merged
Conversation
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
vladbologa
commented
Feb 24, 2025
joelanford
reviewed
Mar 2, 2025
vladbologa
changed the title
joelanford
reviewed
Mar 3, 2025
porridge
reviewed
Mar 3, 2025
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Contributor
|
@vladbologa I've taken the liberty of fixing up the lint complaints - I hope that's ok. If it's green, I'll merge. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 85.06% 78.47% -6.60%
==========================================
Files 19 31 +12
Lines 1346 2518 +1172
==========================================
+ Hits 1145 1976 +831
- Misses 125 451 +326
- Partials 76 91 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upstreams a feature from the https://github.com/stackrox/helm-operator fork used by ACS (Advanced Cluster Security)
Source commit: stackrox/helm-operator@30a1ac3
Original PR: stackrox/helm-operator#29
The PR implements support for a "pause reconcile" handler, which determines if the reconcile should be paused for a given custom resource. Also provided is an implementation for such a handler, that allows pausing reconciliation via a custom annotation that must be added to the CR. If this annotation is set to
truethen the operator does not reconcile the CR.